feat(node): Add time synchronization check to setupOS #3433
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
commented
Jan 14, 2025
Comment on lines
+16
to
+37
| function check_ntp() { | ||
| echo "* Checking Chrony status..." | ||
|
|
||
| systemctl is-active --quiet chrony | ||
| log_and_halt_installation_on_error "$?" "Chrony service not running or not active." | ||
|
|
||
| retries=0 | ||
| max_retries=30 | ||
| while [ "$(timedatectl show -p NTPSynchronized --value)" != "yes" ]; do | ||
| if [ $retries -ge $max_retries ]; then | ||
| local service_logs=$(journalctl -u chrony.service --no-pager) | ||
| local log_message="System clock is not synchronized.\n\nChrony service logs:\n${service_logs}" | ||
| log_and_halt_installation_on_error 1 "${log_message}" | ||
| fi | ||
|
|
||
| echo "* Chrony not yet synchronized. Waiting 2 seconds before retry..." | ||
| sleep 2 | ||
| ((retries++)) | ||
| done | ||
|
|
||
| echo "* Chrony is running and time is in sync." | ||
| } |
There was a problem hiding this comment.
I reran installation a number of times on bare metal, and here are the number of chrony retries each installation took:
- 0
- 12 (24 seconds)
- 12 (24 seconds)
- 12 (24 seconds)
- 0
- 12 (24 seconds)
- 12 (24 seconds)
- 11 (22 seconds)
Is this acceptable to us? We could just roll this out and if it ever causes a false negative, roll it back. I'm not sure this is worth more of a time investment.
Bownairo
approved these changes
Jan 16, 2025
Comment on lines
+41
to
+42
| set_hwclock_utc | ||
| check_ntp |
There was a problem hiding this comment.
I think it makes sense to sync ntp first, then update the hardware clock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-1504